[GH-ISSUE #86] Windows installer/bootstrap is too invasive: overwrites unrelated user settings and causes extension regressions #64

New issue

Open

opened 2026-05-06 13:13:01 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:13:01 +02:00

Owner

Originally created by @Christopher-C-Robinson on GitHub (Feb 20, 2026).
Original GitHub issue: https://github.com/bwya77/vscode-dark-islands/issues/86

Summary

After installing Islands Dark on Windows using the recommended bootstrap/install flow, my VS Code setup changed beyond theme/UI settings. Non-theme extension behavior regressed (example: TestCafe runner custom args stopped behaving as expected), and I had to manually roll back.

Environment

OS: Windows
VS Code: 1.109.5
Repo: bwya77/vscode-dark-islands
Install method used: PowerShell bootstrap/install script

Steps to reproduce

Start with an existing VS Code profile that has non-theme settings for other extensions (example: TestCafe runner custom args).
Run the recommended installer/bootstrap command from this repo on Windows.
Reopen VS Code and use affected extensions.
Inspect user settings and extension behavior.

Actual behavior

User settings were changed in ways unrelated to the Islands theme/UI.
Some extension-related behavior regressed after install.
custom-ui-style patching changed VS Code installation files, and rollback required manual cleanup.

Expected behavior

Installer should only change allowlisted theme/UI keys.
Non-theme settings should be preserved exactly.
Installing custom-ui-style (which patches VS Code internals) should be explicit/opt-in with strong warning and easy rollback.
A dry-run / diff preview would help before writing settings.

Why I think this is happening

install.ps1 appears to merge and apply repo settings with Islands settings taking precedence, and also installs/enables custom-ui-style, which patches VS Code core files. This can affect more than just visual theme behavior.

Suggested fix

Restrict installer writes to a strict allowlist of keys (theme + explicit Islands UI keys only).
Do not touch unrelated keys from user settings.
Add --safe mode that only sets workbench.colorTheme and optional icon theme.
Add a preview of settings diff before apply.
Make custom-ui-style install/apply optional with explicit confirmation.

Originally created by @Christopher-C-Robinson on GitHub (Feb 20, 2026). Original GitHub issue: https://github.com/bwya77/vscode-dark-islands/issues/86 ## Summary After installing Islands Dark on Windows using the recommended bootstrap/install flow, my VS Code setup changed beyond theme/UI settings. Non-theme extension behavior regressed (example: TestCafe runner custom args stopped behaving as expected), and I had to manually roll back. ## Environment - OS: Windows - VS Code: 1.109.5 - Repo: bwya77/vscode-dark-islands - Install method used: PowerShell bootstrap/install script ## Steps to reproduce 1. Start with an existing VS Code profile that has non-theme settings for other extensions (example: TestCafe runner custom args). 2. Run the recommended installer/bootstrap command from this repo on Windows. 3. Reopen VS Code and use affected extensions. 4. Inspect user settings and extension behavior. ## Actual behavior - User settings were changed in ways unrelated to the Islands theme/UI. - Some extension-related behavior regressed after install. - `custom-ui-style` patching changed VS Code installation files, and rollback required manual cleanup. ## Expected behavior - Installer should only change allowlisted theme/UI keys. - Non-theme settings should be preserved exactly. - Installing `custom-ui-style` (which patches VS Code internals) should be explicit/opt-in with strong warning and easy rollback. - A dry-run / diff preview would help before writing settings. ## Why I think this is happening `install.ps1` appears to merge and apply repo settings with Islands settings taking precedence, and also installs/enables `custom-ui-style`, which patches VS Code core files. This can affect more than just visual theme behavior. ## Suggested fix - Restrict installer writes to a strict allowlist of keys (theme + explicit Islands UI keys only). - Do not touch unrelated keys from user settings. - Add `--safe` mode that only sets `workbench.colorTheme` and optional icon theme. - Add a preview of settings diff before apply. - Make `custom-ui-style` install/apply optional with explicit confirmation.