[GH-ISSUE #88] Duplicate style definitions for .monaco-icon-label.file-icon::before #68

Closed
opened 2026-05-06 13:13:02 +02:00 by BreizhHardware · 0 comments

Originally created by @vrcalphabet on GitHub (Feb 21, 2026).
Original GitHub issue: https://github.com/bwya77/vscode-dark-islands/issues/88

I found that the following two selectors define exactly the same styles:

  • .monaco-icon-label.file-icon::before
  • .tab .monaco-icon-label.file-icon::before

https://github.com/bwya77/vscode-dark-islands/blob/main/settings.json#L347-L354

Both apply:

  • filter: drop-shadow(0 0 2.5px currentColor);
  • opacity: 1 !important;

Since the styles are identical, the second selector seems redundant unless there is a specific reason to scope it under .tab.
Removing the duplicate could simplify the theme settings.
I'll open a PR to address this.

Originally created by @vrcalphabet on GitHub (Feb 21, 2026). Original GitHub issue: https://github.com/bwya77/vscode-dark-islands/issues/88 I found that the following two selectors define exactly the same styles: - `.monaco-icon-label.file-icon::before` - `.tab .monaco-icon-label.file-icon::before` https://github.com/bwya77/vscode-dark-islands/blob/main/settings.json#L347-L354 Both apply: - filter: drop-shadow(0 0 2.5px currentColor); - opacity: 1 !important; Since the styles are identical, the second selector seems redundant unless there is a specific reason to scope it under `.tab`. Removing the duplicate could simplify the theme settings. I'll open a PR to address this.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/vscode-dark-islands#68
No description provided.