BreizhHardware/project_sanic
1
0
Fork 0
mirror of https://github.com/BreizhHardware/project_sanic.git synced 2026-05-09 08:15:51 +02:00
Code Issues Projects Packages Wiki Activity

[PR #35] [MERGED] Fix(Player) - Initialize pygame mixer for sound handling; add error h… #35

New issue
Closed
opened 2026-05-06 12:17:27 +02:00 by BreizhHardware · 0 comments
BreizhHardware commented 2026-05-06 12:17:27 +02:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/BreizhHardware/project_sanic/pull/35
Author: @BreizhHardware
Created: 4/9/2025
Status: ✅ Merged
Merged: 4/9/2025
Merged by: @ClementHVT

Base: dev ← Head: dev_felix

📝 Commits (2)

  • 2fbeaaf Fix(Player) - Initialize pygame mixer for sound handling; add error handling for jump sound playback.
  • 6e4f753 Update src/Entity/Player.py

📊 Changes

1 file changed (+8 additions, -2 deletions)

View changed files

📝 src/Entity/Player.py (+8 -2)

📄 Description

This pull request includes changes to the Player class in the src/Entity/Player.py file to add sound functionality using the pygame mixer. The most important changes include initializing the mixer in the constructor and adding error handling for playing the jump sound.

Sound functionality improvements:

  • src/Entity/Player.py: Initialized the pygame mixer in the __init__ method to enable sound playback.
  • src/Entity/Player.py: Added error handling in the move method to catch exceptions when playing the jump sound and print an error message.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/BreizhHardware/project_sanic/pull/35 **Author:** [@BreizhHardware](https://github.com/BreizhHardware) **Created:** 4/9/2025 **Status:** ✅ Merged **Merged:** 4/9/2025 **Merged by:** [@ClementHVT](https://github.com/ClementHVT) **Base:** `dev` ← **Head:** `dev_felix` --- ### 📝 Commits (2) - [`2fbeaaf`](https://github.com/BreizhHardware/project_sanic/commit/2fbeaaf4fbb5372415a989a9501cfe7e1ff21e24) Fix(Player) - Initialize pygame mixer for sound handling; add error handling for jump sound playback. - [`6e4f753`](https://github.com/BreizhHardware/project_sanic/commit/6e4f753a3c43e6a771cea1c315bc9d11015bd8f3) Update src/Entity/Player.py ### 📊 Changes **1 file changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Entity/Player.py` (+8 -2) </details> ### 📄 Description This pull request includes changes to the `Player` class in the `src/Entity/Player.py` file to add sound functionality using the `pygame` mixer. The most important changes include initializing the mixer in the constructor and adding error handling for playing the jump sound. Sound functionality improvements: * [`src/Entity/Player.py`](diffhunk://#diff-c0effc013092db6988c4774ca8aa3c2ca0c1b1890ffeed5401b98d17d217acc2R86-R88): Initialized the `pygame` mixer in the `__init__` method to enable sound playback. * [`src/Entity/Player.py`](diffhunk://#diff-c0effc013092db6988c4774ca8aa3c2ca0c1b1890ffeed5401b98d17d217acc2R301-R305): Added error handling in the `move` method to catch exceptions when playing the jump sound and print an error message. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
BreizhHardware 2026-05-06 12:17:27 +02:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
BreizhHardware-patch-1
dev
dev_table_basse
dev_felix
dev_clement
No results found.
Labels
Clear labels   
pull-request
Mirrored from GitHub Pull Request

No labels
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
BreizhHardware/project_sanic#35
No description provided.