[PR #153] [MERGED] WIP: Since ID, works #1229

New issue

Closed

opened 2026-05-07 01:01:06 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:01:06 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/153
Author: @binwiederhier
Created: 2/26/2022
Status: ✅ Merged
Merged: 2/27/2022
Merged by: @binwiederhier

Base: main ← Head: since-id

📝 Commits (10+)

4af9c07 WIP: Since ID, works
8b32cfa Implement since=ID logic in mem cache; add tests; still failing
7d93b05 Almost there; Replace memCache with :memory: SQLite cache
6dc4e44 Fix tests; remove memory implementation entirely
c21737d Combine tests and all that
f17df1e Combine entirely
e29a18a Add another scheduled message to since ID test
e79dbf4 Docs
4cd30c3 Rename cache to messageCache
324500d Deprecation notice

📊 Changes

13 files changed (+750 additions, -688 deletions)

View changed files

📝 docs/deprecations.md (+8 -0)
📝 docs/subscribe/api.md (+5 -3)
➖ server/cache.go (+0 -25)
➖ server/cache_mem.go (+0 -165)
➖ server/cache_mem_test.go (+0 -43)
➖ server/cache_sqlite_test.go (+0 -158)
➖ server/cache_test.go (+0 -222)
📝 server/message_cache.go (+154 -26)
➕ server/message_cache_test.go (+496 -0)
📝 server/server.go (+38 -30)
📝 server/server_test.go (+4 -7)
📝 server/types.go (+31 -8)
📝 util/util.go (+14 -1)

📄 Description

Implements #151

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/153 **Author:** [@binwiederhier](https://github.com/binwiederhier) **Created:** 2/26/2022 **Status:** ✅ Merged **Merged:** 2/27/2022 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `since-id` --- ### 📝 Commits (10+) - [`4af9c07`](https://github.com/binwiederhier/ntfy/commit/4af9c07577c6d0e86905803cac7e7fa883d04643) WIP: Since ID, works - [`8b32cfa`](https://github.com/binwiederhier/ntfy/commit/8b32cfaaffd8a199af29cb48f9da66689efb9c1c) Implement since=ID logic in mem cache; add tests; still failing - [`7d93b05`](https://github.com/binwiederhier/ntfy/commit/7d93b0596b6959012fc924652dcbc00bb4216cdc) Almost there; Replace memCache with :memory: SQLite cache - [`6dc4e44`](https://github.com/binwiederhier/ntfy/commit/6dc4e441e40bcb9ed2cc98b0a5c045e56ead1ded) Fix tests; remove memory implementation entirely - [`c21737d`](https://github.com/binwiederhier/ntfy/commit/c21737d546b6ecf7f7dabc5cd4d3db04b35db22f) Combine tests and all that - [`f17df1e`](https://github.com/binwiederhier/ntfy/commit/f17df1e92615a69b3041776df5ba0f8735e7fd0c) Combine entirely - [`e29a18a`](https://github.com/binwiederhier/ntfy/commit/e29a18a076a13484c0186fe13f60f31688bacdde) Add another scheduled message to since ID test - [`e79dbf4`](https://github.com/binwiederhier/ntfy/commit/e79dbf4d00f04d7d312c16891c19f2468ecbc3dc) Docs - [`4cd30c3`](https://github.com/binwiederhier/ntfy/commit/4cd30c35ce396efb135b50fc66d4232d7afdf046) Rename cache to messageCache - [`324500d`](https://github.com/binwiederhier/ntfy/commit/324500d0b3cb8cbed1e0406490728dfe2aba1cad) Deprecation notice ### 📊 Changes **13 files changed** (+750 additions, -688 deletions) <details> <summary>View changed files</summary> 📝 `docs/deprecations.md` (+8 -0) 📝 `docs/subscribe/api.md` (+5 -3) ➖ `server/cache.go` (+0 -25) ➖ `server/cache_mem.go` (+0 -165) ➖ `server/cache_mem_test.go` (+0 -43) ➖ `server/cache_sqlite_test.go` (+0 -158) ➖ `server/cache_test.go` (+0 -222) 📝 `server/message_cache.go` (+154 -26) ➕ `server/message_cache_test.go` (+496 -0) 📝 `server/server.go` (+38 -30) 📝 `server/server_test.go` (+4 -7) 📝 `server/types.go` (+31 -8) 📝 `util/util.go` (+14 -1) </details> ### 📄 Description Implements #151 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>