[PR #749] [MERGED] Switch to Vite #1403

New issue

Closed

opened 2026-05-07 01:01:57 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:01:57 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/749
Author: @nimbleghost
Created: 5/24/2023
Status: ✅ Merged
Merged: 5/25/2023
Merged by: @binwiederhier

Base: main ← Head: switch-to-vite

📝 Commits (7)

d7eb120 Add eslint with eslint-config-airbnb
f558b4d Add .jsx filename extension
8319f1c Run eslint autofixes
59011c8 Make manual eslint fixes
951c907 Add eslint commits to .git-blame-ignore-revs
e21327c Add vite
d625a00 Use esm mui imports for Vite compatibility

📊 Changes

49 files changed (+4041 additions, -17950 deletions)

View changed files

📝 .git-blame-ignore-revs (+4 -0)
📝 Makefile (+5 -3)
📝 server/server_test.go (+1 -1)
➕ web/.eslintignore (+1 -0)
➕ web/.eslintrc (+31 -0)
📝 web/.prettierignore (+1 -0)
📝 web/index.html (+6 -5)
📝 web/package-lock.json (+3096 -17062)
📝 web/package.json (+14 -6)
📝 web/src/app/AccountApi.js (+26 -25)
📝 web/src/app/Api.js (+6 -5)
📝 web/src/app/Connection.js (+9 -7)
📝 web/src/app/ConnectionManager.js (+9 -10)
📝 web/src/app/Notifier.js (+2 -2)
📝 web/src/app/Poller.js (+2 -0)
📝 web/src/app/SubscriptionManager.js (+22 -14)
📝 web/src/app/config.js (+1 -1)
📝 web/src/app/errors.js (+37 -32)
📝 web/src/app/utils.js (+70 -83)
📝 web/src/components/Account.jsx (+51 -61)

...and 29 more files

📄 Description

This is baed on #748, so should either probably be rebased and reviewed after merging that. It's not that simple to do chained PRs across forks haha.

Actual diff: https://github.com/nimbleghost/ntfy/compare/add-eslint...switch-to-vite?expand=1

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/749 **Author:** [@nimbleghost](https://github.com/nimbleghost) **Created:** 5/24/2023 **Status:** ✅ Merged **Merged:** 5/25/2023 **Merged by:** [@binwiederhier](https://github.com/binwiederhier) **Base:** `main` ← **Head:** `switch-to-vite` --- ### 📝 Commits (7) - [`d7eb120`](https://github.com/binwiederhier/ntfy/commit/d7eb1206fe3b4d78ea90e4d5d0fb3a3c35254ac8) Add eslint with eslint-config-airbnb - [`f558b4d`](https://github.com/binwiederhier/ntfy/commit/f558b4dbe9bb5b9e0e87fada1215de2558353173) Add `.jsx` filename extension - [`8319f1c`](https://github.com/binwiederhier/ntfy/commit/8319f1cf26113167fb29fe12edaff5db74caf35f) Run eslint autofixes - [`59011c8`](https://github.com/binwiederhier/ntfy/commit/59011c8a32b210448f391277a735e0c2d5f7f11e) Make manual eslint fixes - [`951c907`](https://github.com/binwiederhier/ntfy/commit/951c90763afa4f7b2341f9220f4c1719efbf26d3) Add eslint commits to .git-blame-ignore-revs - [`e21327c`](https://github.com/binwiederhier/ntfy/commit/e21327cec59a3b7e8c7a6c3ef723ed6baeebf722) Add vite - [`d625a00`](https://github.com/binwiederhier/ntfy/commit/d625a003b80510785a76550da22e40a125c8bfd0) Use esm mui imports for Vite compatibility ### 📊 Changes **49 files changed** (+4041 additions, -17950 deletions) <details> <summary>View changed files</summary> 📝 `.git-blame-ignore-revs` (+4 -0) 📝 `Makefile` (+5 -3) 📝 `server/server_test.go` (+1 -1) ➕ `web/.eslintignore` (+1 -0) ➕ `web/.eslintrc` (+31 -0) 📝 `web/.prettierignore` (+1 -0) 📝 `web/index.html` (+6 -5) 📝 `web/package-lock.json` (+3096 -17062) 📝 `web/package.json` (+14 -6) 📝 `web/src/app/AccountApi.js` (+26 -25) 📝 `web/src/app/Api.js` (+6 -5) 📝 `web/src/app/Connection.js` (+9 -7) 📝 `web/src/app/ConnectionManager.js` (+9 -10) 📝 `web/src/app/Notifier.js` (+2 -2) 📝 `web/src/app/Poller.js` (+2 -0) 📝 `web/src/app/SubscriptionManager.js` (+22 -14) 📝 `web/src/app/config.js` (+1 -1) 📝 `web/src/app/errors.js` (+37 -32) 📝 `web/src/app/utils.js` (+70 -83) 📝 `web/src/components/Account.jsx` (+51 -61) _...and 29 more files_ </details> ### 📄 Description This is baed on #748, so should either probably be rebased and reviewed after merging that. It's not that simple to do chained PRs across forks haha. Actual diff: https://github.com/nimbleghost/ntfy/compare/add-eslint...switch-to-vite?expand=1 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>