starred/ntfy

Fork 0

mirror of https://github.com/binwiederhier/ntfy.git synced 2026-05-09 08:26:00 +02:00

[GH-ISSUE #203] Web App: Strings with issues #162

New issue

Closed

opened 2026-05-07 00:20:49 +02:00 by BreizhHardware · 9 comments

BreizhHardware commented

2026-05-07 00:20:49 +02:00

Owner

Originally created by @StoyanDimitrov on GitHub (Apr 8, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/203

notifications_loading aren't we talking about messages everywhere in the web app UI?
publish_dialog_attachment_limits_quota_reached missing space after the comma
what are the gotchas when translating publish_dialog_delay_placeholder?

Originally created by @StoyanDimitrov on GitHub (Apr 8, 2022). Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/203 - `notifications_loading` aren't we talking about *messages* everywhere in the web app UI? - `publish_dialog_attachment_limits_quota_reached` missing space after the comma - what are the gotchas when translating `publish_dialog_delay_placeholder`?

BreizhHardware

2026-05-07 00:20:49 +02:00

closed this issue
added the
🪲 bug

web-app
labels

BreizhHardware commented

2026-05-07 00:20:50 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 8, 2022):

notifications_loading

It's a horrible mix of "message" and "notification". I see that now.

The pubsub protocol calls it message, but the UI typically calls it notification. But a notification has a message in the JSON, so 🤷 Let me review it all.

publish_dialog_delay_placeholder

"tomorrow, 9am" -- Only English is supported, so I'd leave that.

@binwiederhier commented on GitHub (Apr 8, 2022): > notifications_loading It's a horrible mix of "message" and "notification". I see that now. The pubsub protocol calls it message, but the UI typically calls it notification. But a notification has a message in the JSON, so :shrug: Let me review it all. > publish_dialog_delay_placeholder "tomorrow, 9am" -- Only English is supported, so I'd leave that.

BreizhHardware commented

2026-05-07 00:20:50 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 8, 2022):

I think I fixed the notification/message thing and your other comments, as per github.com/binwiederhier/ntfy@d2f933e15f

"Message" only appears now when the message body is referenced.

@binwiederhier commented on GitHub (Apr 8, 2022): I think I fixed the notification/message thing and your other comments, as per https://github.com/binwiederhier/ntfy/commit/d2f933e15f51d6852af8af44ddadc2c90b3ac108 "Message" only appears now when the message body is referenced.

BreizhHardware commented

2026-05-07 00:20:50 +02:00

Author

Owner

@StoyanDimitrov commented on GitHub (Apr 8, 2022):

I feel like prefs_notifications_min_priority_title - "Minimum priority" needs some explanation. It's not immediately clear where this setting applies. The Android app has brief description that gives the needed context.

@StoyanDimitrov commented on GitHub (Apr 8, 2022): I feel like `prefs_notifications_min_priority_title` - "Minimum priority" needs some explanation. It's not immediately clear where this setting applies. The Android app has brief description that gives the needed context.

BreizhHardware commented

2026-05-07 00:20:50 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 8, 2022):

"Minimum priority" needs some explanation.

Hmm. You may be right. I'd have to add some detailed description text for each of the settings. Let me think about how to do that in the UI 🤔

@binwiederhier commented on GitHub (Apr 8, 2022): > "Minimum priority" needs some explanation. Hmm. You may be right. I'd have to add some detailed description text for each of the settings. Let me think about how to do that in the UI :thinking:

BreizhHardware commented

2026-05-07 00:20:51 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 9, 2022):

What do you think?

@binwiederhier commented on GitHub (Apr 9, 2022): ![220409 19-16-25 Selection 001](https://user-images.githubusercontent.com/664597/162594677-2a07b20a-da07-456b-bcd9-94949fdf7cc2.png) What do you think?

BreizhHardware commented

2026-05-07 00:20:51 +02:00

Author

Owner

@StoyanDimitrov commented on GitHub (Apr 10, 2022):

Looking good. It's nice addition.

@StoyanDimitrov commented on GitHub (Apr 10, 2022): Looking good. It's nice addition.

BreizhHardware commented

2026-05-07 00:20:51 +02:00

Author

Owner

@StoyanDimitrov commented on GitHub (Apr 10, 2022):

Is it possible on notifications_no_subscriptions_description (Click the "Add subscription" link to create or subscribe to a topic. After that, you can send messages via PUT or POST and you'll receive notifications here.) to use placeholder with the actual button label - nav_button_subscribe? The text of the button already changed to "Subscribe to topic".

@StoyanDimitrov commented on GitHub (Apr 10, 2022): Is it possible on `notifications_no_subscriptions_description` (Click the "Add subscription" link to create or subscribe to a topic. After that, you can send messages via PUT or POST and you'll receive notifications here.) to use placeholder with the actual button label - `nav_button_subscribe`? The text of the button already changed to "Subscribe to topic".

BreizhHardware commented

2026-05-07 00:20:51 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 10, 2022):

Done.

@binwiederhier commented on GitHub (Apr 10, 2022): Done.

BreizhHardware commented

2026-05-07 00:20:51 +02:00

Author

Owner

@binwiederhier commented on GitHub (Apr 10, 2022):

I'll close this for now, but you can keep adding if you find more issues.

@binwiederhier commented on GitHub (Apr 10, 2022): I'll close this for now, but you can keep adding if you find more issues.

BreizhHardware referenced this issue

2026-05-07 00:25:03 +02:00

[GH-ISSUE #711] Build Errors On FreeBSD #520