[PR #1696] Include Darwin in the serve Unix build #1696

New issue

Open

opened 2026-05-07 01:03:16 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 01:03:16 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/binwiederhier/ntfy/pull/1696
Author: @ShipItAndPray
Created: 4/12/2026
Status: 🔄 Open

Base: main ← Head: fix/darwin-serve-build

📝 Commits (1)

82e9dfe Include Darwin in the serve Unix build

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 cmd/serve_unix.go (+1 -1)

📄 Description

Summary

include macOS in the Unix serve implementation so Darwin builds get maybeRunAsService and sigHandlerConfigReload
keep the change minimal by extending the existing non-Windows build tag instead of introducing a separate Darwin stub

Fixes #1631

Validation

git diff --check
attempted local go build . validation on darwin after creating temporary placeholder embed dirs for server/docs and server/site

Notes

the current checkout is missing embedded server/docs and server/site content, so the local build cannot complete end-to-end without temporary placeholders
the underlying compile issue from #1631 is addressed by making cmd/serve_unix.go build on Darwin as well

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/binwiederhier/ntfy/pull/1696 **Author:** [@ShipItAndPray](https://github.com/ShipItAndPray) **Created:** 4/12/2026 **Status:** 🔄 Open **Base:** `main` ← **Head:** `fix/darwin-serve-build` --- ### 📝 Commits (1) - [`82e9dfe`](https://github.com/binwiederhier/ntfy/commit/82e9dfe8f160e8c48302b13ad3aab812b8482fa6) Include Darwin in the serve Unix build ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `cmd/serve_unix.go` (+1 -1) </details> ### 📄 Description ## Summary - include macOS in the Unix serve implementation so Darwin builds get `maybeRunAsService` and `sigHandlerConfigReload` - keep the change minimal by extending the existing non-Windows build tag instead of introducing a separate Darwin stub Fixes #1631 ## Validation - git diff --check - attempted local `go build .` validation on darwin after creating temporary placeholder embed dirs for `server/docs` and `server/site` ## Notes - the current checkout is missing embedded `server/docs` and `server/site` content, so the local build cannot complete end-to-end without temporary placeholders - the underlying compile issue from #1631 is addressed by making `cmd/serve_unix.go` build on Darwin as well --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>