mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #744] Web app build / dev tooling - Vite, prettier, eslint? #543
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#543
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @nimbleghost on GitHub (May 23, 2023).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/744
💡 Idea
I'd like to try tackling #199 / #346, but would like to make some development / build improvements first if they sound good to you.
I would switch to Vite to make https testing easier for notifications (and though not deprecated, CRA isn't recommended anymore anyway), plus would add eslint and prettier for static analysis and formatting.
💻 Target components
web app
@binwiederhier commented on GitHub (May 23, 2023):
Those all sound like awesome things! Amazing!
I am happy to chat on Discord/Matrix about details if you like, and I ask that you try to do small-ish PRs if possible, and that you discuss the design beforehand if there are many changes.
As for Web Push, I don't fully understand what that means server-side, so maybe you'll have to enlighten me.
@nimbleghost commented on GitHub (May 23, 2023):
Sounds great! I will comment on the web push issue once I get to it.
r.e. Discord/Matrix yes - will take a look later.
@binwiederhier commented on GitHub (May 23, 2023):
It is worth noting that the PWA has been attempted before, so maybe check that code too when you get there.
@nimbleghost commented on GitHub (May 24, 2023):
Resolved by #747, #748, #749