mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 16:35:53 +02:00
[GH-ISSUE #83] RPM installation is not creating needed Linux user/group "ntfy" #67
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#67
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @cmeis on GitHub (Jan 4, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/83
The installation via RPM doesn't create the user/group "ntfy" referenced in the systemd service config file. Tested using current version 1.11.2.
This leads to the service not starting:
Manually creating this user/group solves the problem for now
@binwiederhier commented on GitHub (Jan 4, 2022):
It was a late addition to add the user. If you can provide a PR to fix it that would help. If not I'll get to it eventually. My apologies.
@cmeis commented on GitHub (Jan 4, 2022):
Hm, just had a look at the postinst.sh / postrm.sh and they both seem to contain the necessary code the create/delete the user.
The problem will be that I'm testing on a RedHat flavour system, where the parameters to the postinst.sh/postrm.sh seem to be different.
Where $1 is "configure" or "purge" on Debian (which is in your code), RedHat-flavoured systems will use a "1" for upgrade (and install?) and a "0" for removal.
I'll try to whip up some dev VM to be able to build the rpm and test myself...
@binwiederhier commented on GitHub (Jan 4, 2022):
That's what I figured. It would be super awesome if you could fix those. If not, I'll probably figure something out, but it won't be today. :-)
@cmeis commented on GitHub (Jan 5, 2022):
I spent some hours yesterday trying to build ntfy locally.
No joy in RHEL world (missing cross compilers).
Installed an Ubuntu 20.04 workstation with development tools, but only ALMOST managed to get a build running through correctly.
Not sure where I'm going wrong, but will probably only find time to continue this next week...
@binwiederhier commented on GitHub (Jan 5, 2022):
I am very sorry you had such a hard time. The static linking and cross compiling and the docs issue make it annoying and hard.
I need to make that easier, and also make it build in a GitHub action.
@cmeis commented on GitHub (Jan 5, 2022):
Just created a pull request. No regular GitHub user here, so please bear with me ;-)
As I wasn't able to build the RPM locally, I used the rpmrebuild tool to modify the scriptlets in the official 1.11.2 rpm for local testing. In my testing users are created/removed correctly now on RHEL-flavoured Linux (tested on CentOS 8 and AlmaLinux 8).
@binwiederhier commented on GitHub (Jan 5, 2022):
Awesome, and the pull request looks great. I let some comments for you.