mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 16:35:53 +02:00
[GH-ISSUE #101] Binary UnifiedPush messages should not be converted to attachments #83
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#83
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @binwiederhier on GitHub (Jan 17, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/101
@binwiederhier commented on GitHub (Jan 17, 2022):
Server side
github.com/binwiederhier/ntfy@4ceb058a40@binwiederhier commented on GitHub (Jan 18, 2022):
This is done in both main branches.
@karmanyaahm commented on GitHub (Jan 18, 2022):
So I tested out the android app, and it didn't seem to work with flutter's byte decoding things, so I made this commit to ntfy for debugging:
github.com/karmanyaahm/ntfy-android@f96fec2ff3After that, I sent messages with
dd if=/dev/urandom bs=8 count=1 | curl -d @- http://localhost/upABC?up=1and monitored the logs printed by the above commit by running
adb logcat | grep Ntfy2.There, I could see something like the following
The output from the base64 array print was the correct (albeit signed) bytes, while the output after encoding into a string and decoding was the second weird one. The second output was also the same as what up-flutter-example saw when decoding the string to bytes.
So, this makes it seem like converting the byte array derived from base64 into a string is causing some corruption of the data. The effects are also inconsistent based on the input (random) data, so different characters are being processed differently.
I have no idea why any of this is happening, or whether it is even reproducible on different devices.
@karmanyaahm commented on GitHub (Jan 18, 2022):
https://stackoverflow.com/a/9098905/8919142 💭