mirror of
https://github.com/binwiederhier/ntfy.git
synced 2026-05-09 08:26:00 +02:00
[GH-ISSUE #120] App icon does not show up on Android 7 #98
Labels
No labels
ai-generated
android-app
android-app
android-app
🪲 bug
build
build
dependencies
docs
enhancement
enhancement
🔥 HOT
in-progress 🏃
ios
prio:low
prio:low
pull-request
question
🔒 security
server
server
unified-push
web-app
website
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/ntfy#98
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @shadow00 on GitHub (Jan 28, 2022).
Original GitHub issue: https://github.com/binwiederhier/ntfy/issues/120
Just installed ntfy (v1.7.2, from F-Droid) on an Android 7.0 device, and the app icon does not show up. Looks like it's using the stock Android template icon.
On my Android 8.1 phone it shows up fine.
@binwiederhier commented on GitHub (Jan 28, 2022):
I have seen this in the emulator but haven't had the time to find out why. Thanks for reporting.
@binwiederhier commented on GitHub (Mar 13, 2022):
I spent 30min on this, and even with extensive googling, I couldn't figure out what is wrong. Stack overflow points to
roundIconas the culprit, but I have that set properly:Given that only 15 devices out of the almost 600 are using Android 7 or older I am going to close this for now. If this really bothers you, I can give it another shot.
@shadow00 You could find an open source app that has the icon set correctly and link that here. That may help.
For now, I'll close the ticket, but I'm more than happy to re-open in case there are new developments.
@shadow00 commented on GitHub (Apr 26, 2022):
Sorry for the late reply, I got distracted by other stuff and forgot to reply. Here are a few f-droid apps with working icons:
I assume you've already seen this, but just in case: some of the replies suggest deleting the
android:roundIcon="@mipmap/ic_launcher_round"line entirely and using onlyandroid:iconwhen targeting a lower API version; one of the comments mentions a bug in Android Studio that adds it back by mistake even when you remove it.It's not a critical bug though, so if you want to prioritize other issues that's fine :)
@binwiederhier commented on GitHub (May 1, 2022):
I looked at https://github.com/nextcloud/android/blob/master/app/src/main/AndroidManifest.xml and have a first success on SDK 24 (🥳)
@binwiederhier commented on GitHub (May 1, 2022):
Thanks for the example @shadow00; now it'll hopefully be easy.
@binwiederhier commented on GitHub (May 2, 2022):
Fixed in
github.com/binwiederhier/ntfy-android@a2551bc7f0, will be in next release.Turns out I had to generate a Legacy icon (which I had done before ...) with the "Trim" option. No idea why, but apparently that generates the combined images, as opposed to foreground and background separately: