[PR #94] [MERGED] Remove GameQ and use "own" implementation for queries #107

New issue

Closed

opened 2026-05-07 00:18:08 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented 2026-05-07 00:18:08 +02:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/94
Author: @Boy132
Created: 1/27/2026
Status: ✅ Merged
Merged: 1/27/2026
Merged by: @Boy132

Base: main ← Head: player-counter/remove-gameq

---

📝 Commits (10+)

• 8d949d5 remove gameq and use "own" implementation for queries
• 4884323 update readme
• be92047 remove gameq from workflow
• ca5b66b better error handling
• 2fae786 fix minecraft hostname
• f280dfd pint
• c2cba24 more minecraft fixes
• 082e40e fix player mapping for minecraft query
• 0aeab1d fix player list on bedrock
• c617073 better check for allocation ip

📊 Changes

18 files changed (+493 additions, -169 deletions)

View changed files

📝 .github/workflows/lint.yml (+2 -3)
📝 player-counter/README.md (+3 -6)
📝 player-counter/database/Seeders/PlayerCounterSeeder.php (+79 -24)
📝 player-counter/plugin.json (+2 -1)
➖ player-counter/src/Enums/GameQueryType.php (+0 -58)
➕ player-counter/src/Extensions/Query/QueryTypeSchemaInterface.php (+13 -0)
➕ player-counter/src/Extensions/Query/QueryTypeService.php (+29 -0)
➕ player-counter/src/Extensions/Query/Schemas/CitizenFXQueryTypeSchema.php (+73 -0)
➕ player-counter/src/Extensions/Query/Schemas/GoldSourceQueryTypeSchema.php (+24 -0)
➕ player-counter/src/Extensions/Query/Schemas/MinecraftBedrockQueryTypeSchema.php (+48 -0)
➕ player-counter/src/Extensions/Query/Schemas/MinecraftJavaQueryTypeSchema.php (+85 -0)
➕ player-counter/src/Extensions/Query/Schemas/SourceQueryTypeSchema.php (+53 -0)
📝 player-counter/src/Filament/Admin/Resources/GameQueries/GameQueryResource.php (+4 -4)
📝 player-counter/src/Filament/Server/Pages/PlayersPage.php (+26 -23)
📝 player-counter/src/Filament/Server/Widgets/ServerPlayerWidget.php (+5 -5)
📝 player-counter/src/Http/Controllers/Api/Client/Servers/PlayerCounterController.php (+9 -10)
📝 player-counter/src/Models/GameQuery.php (+19 -35)
📝 player-counter/src/Providers/PlayerCounterPluginProvider.php (+19 -0)

📄 Description

Summary by CodeRabbit

• New Features

  • Added a registry and multiple new server query processors for broader protocol support and admin configurability.

• Improvements

  • Dual-path Minecraft querying (legacy + ping) and safer handling of absent/null query data; admin UI and player actions consistently use player names; centralized query availability checks.

• Documentation

  • Updated setup guidance to emphasize public IP allocation and Minecraft query recommendations.

• Dependencies

  • Replaced legacy query dependency with newer Minecraft/Source query libraries.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/94 **Author:** [@Boy132](https://github.com/Boy132) **Created:** 1/27/2026 **Status:** ✅ Merged **Merged:** 1/27/2026 **Merged by:** [@Boy132](https://github.com/Boy132) **Base:** `main` ← **Head:** `player-counter/remove-gameq` --- ### 📝 Commits (10+) - [`8d949d5`](https://github.com/pelican-dev/plugins/commit/8d949d517411400410c7417055442f61f7cb10ab) remove gameq and use "own" implementation for queries - [`4884323`](https://github.com/pelican-dev/plugins/commit/488432392213f353af259ee6b1b8e3d3390bd6e7) update readme - [`be92047`](https://github.com/pelican-dev/plugins/commit/be9204728f502238508145da3edc6b2aa794d2aa) remove gameq from workflow - [`ca5b66b`](https://github.com/pelican-dev/plugins/commit/ca5b66b9fa20ac56199907e75c3c0e5792ad6cd8) better error handling - [`2fae786`](https://github.com/pelican-dev/plugins/commit/2fae7865065d144c8bf1e24c6544f8486a861364) fix minecraft hostname - [`f280dfd`](https://github.com/pelican-dev/plugins/commit/f280dfd2d395fb6f2b215c369d689d70731031d3) pint - [`c2cba24`](https://github.com/pelican-dev/plugins/commit/c2cba24dc37c425ecb249f753002cf0f3341af7d) more minecraft fixes - [`082e40e`](https://github.com/pelican-dev/plugins/commit/082e40e6d8a42c689af11abf2f7687eefd241dc3) fix player mapping for minecraft query - [`0aeab1d`](https://github.com/pelican-dev/plugins/commit/0aeab1d3e646377b955f14ffd5100bc27099526f) fix player list on bedrock - [`c617073`](https://github.com/pelican-dev/plugins/commit/c61707389e4e4a7391a50aaad12b4863df410da3) better check for allocation ip ### 📊 Changes **18 files changed** (+493 additions, -169 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/lint.yml` (+2 -3) 📝 `player-counter/README.md` (+3 -6) 📝 `player-counter/database/Seeders/PlayerCounterSeeder.php` (+79 -24) 📝 `player-counter/plugin.json` (+2 -1) ➖ `player-counter/src/Enums/GameQueryType.php` (+0 -58) ➕ `player-counter/src/Extensions/Query/QueryTypeSchemaInterface.php` (+13 -0) ➕ `player-counter/src/Extensions/Query/QueryTypeService.php` (+29 -0) ➕ `player-counter/src/Extensions/Query/Schemas/CitizenFXQueryTypeSchema.php` (+73 -0) ➕ `player-counter/src/Extensions/Query/Schemas/GoldSourceQueryTypeSchema.php` (+24 -0) ➕ `player-counter/src/Extensions/Query/Schemas/MinecraftBedrockQueryTypeSchema.php` (+48 -0) ➕ `player-counter/src/Extensions/Query/Schemas/MinecraftJavaQueryTypeSchema.php` (+85 -0) ➕ `player-counter/src/Extensions/Query/Schemas/SourceQueryTypeSchema.php` (+53 -0) 📝 `player-counter/src/Filament/Admin/Resources/GameQueries/GameQueryResource.php` (+4 -4) 📝 `player-counter/src/Filament/Server/Pages/PlayersPage.php` (+26 -23) 📝 `player-counter/src/Filament/Server/Widgets/ServerPlayerWidget.php` (+5 -5) 📝 `player-counter/src/Http/Controllers/Api/Client/Servers/PlayerCounterController.php` (+9 -10) 📝 `player-counter/src/Models/GameQuery.php` (+19 -35) 📝 `player-counter/src/Providers/PlayerCounterPluginProvider.php` (+19 -0) </details> ### 📄 Description <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added a registry and multiple new server query processors for broader protocol support and admin configurability. * **Improvements** * Dual-path Minecraft querying (legacy + ping) and safer handling of absent/null query data; admin UI and player actions consistently use player names; centralized query availability checks. * **Documentation** * Updated setup guidance to emphasize public IP allocation and Minecraft query recommendations. * **Dependencies** * Replaced legacy query dependency with newer Minecraft/Source query libraries. _{✏️ Tip: You can customize this high-level summary in your review settings.} <!-- end of auto-generated comment: release notes by coderabbit.ai --> --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

BreizhHardware 2026-05-07 00:18:08 +02:00

• closed this issue
• added the
  pull-request
  label

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

register/email-verification

No results found.

Labels

Clear labels   

pull-request

Mirrored from GitHub Pull Request

No labels

pull-request

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/plugins#107

No description provided.