[PR #67] [CLOSED] SRV records support with endpoint notifications #94

New issue

Closed

opened 2026-05-07 00:18:03 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-07 00:18:03 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/pelican-dev/plugins/pull/67
Author: @HarlequinSin
Created: 12/28/2025
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (10+)

e603353 add srv_target column to cloudflare_domains migration
5948e9c add SRV record and target strings
cc76657 add srv_target field to CloudflareDomain model and resource
e17c617 add srv_record toggle to SubdomainRelationManager and SubdomainResource
2e72466 Adding logic for srv records
f20e58e add error messages for missing SRV target and enhance tooltip logic in SubdomainResource
58de843 add zone request status messages and improve logging for missing SRV record target or port
2ff7a99 add CloudflareService class for managing DNS records with upsert and delete functionality
1572187 cleanup
eb1a0eb Remade script to utilize upsert with better error handling

📊 Changes

13 files changed (+733 additions, -68 deletions)

View changed files

📝 subdomains/README.md (+42 -1)
➕ subdomains/database/migrations/004_add_srv_target_to_nodes.php (+45 -0)
📝 subdomains/lang/en/strings.php (+54 -2)
➕ subdomains/src/Enums/ServiceRecordType.php (+55 -0)
📝 subdomains/src/Filament/Admin/Resources/CloudflareDomains/Pages/ManageCloudflareDomains.php (+2 -1)
📝 subdomains/src/Filament/Admin/Resources/Servers/RelationManagers/SubdomainRelationManager.php (+6 -4)
➕ subdomains/src/Filament/Components/Actions/SetSrvTargetAction.php (+46 -0)
📝 subdomains/src/Filament/Server/Resources/Subdomains/SubdomainResource.php (+18 -10)
📝 subdomains/src/Models/CloudflareDomain.php (+21 -2)
📝 subdomains/src/Models/Subdomain.php (+223 -46)
📝 subdomains/src/Providers/SubdomainsPluginProvider.php (+5 -1)
➕ subdomains/src/Services/CloudflareService.php (+215 -0)
📝 subdomains/src/SubdomainsPlugin.php (+1 -1)

📄 Description

There are some pretty sweeping changes here, but they can be summarized in to the following:

Notification changes to reflect if DNS records updated in cloudflare
Extracting CloudFlare methods into seperate file/class
SRV record type toggle

Let me know if there are any issues (honestly never made a PR before and this is my first time with PHP)

Summary by CodeRabbit

Release Notes

New Features
- Added SRV record support for popular games (Minecraft, Rust, Factorio, TeamSpeak, Mumble, SCPSL).
- Record type now visible in subdomain management interface.
- Domain name suffix displayed in subdomain forms for clarity.
Documentation
- Enhanced README with supported games, SRV requirements, troubleshooting guide, and configuration examples.
Improvements
- Streamlined notification handling for subdomain operations.
- Expanded translation strings for SRV messaging and settings feedback.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/pelican-dev/plugins/pull/67 **Author:** [@HarlequinSin](https://github.com/HarlequinSin) **Created:** 12/28/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (10+) - [`e603353`](https://github.com/pelican-dev/plugins/commit/e6033538be9f78f39ab4432b6e9e015a5874279e) add srv_target column to cloudflare_domains migration - [`5948e9c`](https://github.com/pelican-dev/plugins/commit/5948e9c4b5994b29169fa5ab633fcae4de9ca1f8) add SRV record and target strings - [`cc76657`](https://github.com/pelican-dev/plugins/commit/cc7665723a954b3c3eb82760ce89317f035174db) add srv_target field to CloudflareDomain model and resource - [`e17c617`](https://github.com/pelican-dev/plugins/commit/e17c6171409532df6212c919a71df46fc29b4a2b) add srv_record toggle to SubdomainRelationManager and SubdomainResource - [`2e72466`](https://github.com/pelican-dev/plugins/commit/2e7246634d4fc1f449a3b47d34c132fb0862ba39) Adding logic for srv records - [`f20e58e`](https://github.com/pelican-dev/plugins/commit/f20e58eb3ac8162632c097637fc8a75229a16734) add error messages for missing SRV target and enhance tooltip logic in SubdomainResource - [`58de843`](https://github.com/pelican-dev/plugins/commit/58de843308a8051078b6045aacf77fd610b77488) add zone request status messages and improve logging for missing SRV record target or port - [`2ff7a99`](https://github.com/pelican-dev/plugins/commit/2ff7a9956ac1d7e2bfe9d9705eaf088681bb7dc9) add CloudflareService class for managing DNS records with upsert and delete functionality - [`1572187`](https://github.com/pelican-dev/plugins/commit/15721872d7477e2bb85de50d94ca30417a43887c) cleanup - [`eb1a0eb`](https://github.com/pelican-dev/plugins/commit/eb1a0ebbb28b5faf6b34793e99350a08eedb7be7) Remade script to utilize upsert with better error handling ### 📊 Changes **13 files changed** (+733 additions, -68 deletions) <details> <summary>View changed files</summary> 📝 `subdomains/README.md` (+42 -1) ➕ `subdomains/database/migrations/004_add_srv_target_to_nodes.php` (+45 -0) 📝 `subdomains/lang/en/strings.php` (+54 -2) ➕ `subdomains/src/Enums/ServiceRecordType.php` (+55 -0) 📝 `subdomains/src/Filament/Admin/Resources/CloudflareDomains/Pages/ManageCloudflareDomains.php` (+2 -1) 📝 `subdomains/src/Filament/Admin/Resources/Servers/RelationManagers/SubdomainRelationManager.php` (+6 -4) ➕ `subdomains/src/Filament/Components/Actions/SetSrvTargetAction.php` (+46 -0) 📝 `subdomains/src/Filament/Server/Resources/Subdomains/SubdomainResource.php` (+18 -10) 📝 `subdomains/src/Models/CloudflareDomain.php` (+21 -2) 📝 `subdomains/src/Models/Subdomain.php` (+223 -46) 📝 `subdomains/src/Providers/SubdomainsPluginProvider.php` (+5 -1) ➕ `subdomains/src/Services/CloudflareService.php` (+215 -0) 📝 `subdomains/src/SubdomainsPlugin.php` (+1 -1) </details> ### 📄 Description There are some pretty sweeping changes here, but they can be summarized in to the following: 1. Notification changes to reflect if DNS records updated in cloudflare 2. Extracting CloudFlare methods into seperate file/class 3. SRV record type toggle Let me know if there are any issues (honestly never made a PR before and this is my first time with PHP)  ## Summary by CodeRabbit ## Release Notes * **New Features** * Added SRV record support for popular games (Minecraft, Rust, Factorio, TeamSpeak, Mumble, SCPSL). * Record type now visible in subdomain management interface. * Domain name suffix displayed in subdomain forms for clarity. * **Documentation** * Enhanced README with supported games, SRV requirements, troubleshooting guide, and configuration examples. * **Improvements** * Streamlined notification handling for subdomain operations. * Expanded translation strings for SRV messaging and settings feedback. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub>  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>