[GH-ISSUE #22] Code visible in browser bar #4

New issue

Closed

opened 2026-05-07 00:17:09 +02:00 by BreizhHardware · 2 comments

BreizhHardware commented

2026-05-07 00:17:09 +02:00

Owner

Originally created by @aroundmyroom on GitHub (Dec 18, 2022).
Original GitHub issue: https://github.com/glenndehaan/unifi-voucher-site/issues/22

when entering the 'code' its hidden

but as it is passed as URL two things happen

the URL: voucher?code=1234&type=480,0,,, is shown

Result: the code is visible which can become a potential issue

When reloading the page: the system is creating multiple vouchers (when reloading multiple times)
System is not aware that there are more options for creating a voucher (week/year), than you need to press the logo again (which can be intentionally)

Originally created by @aroundmyroom on GitHub (Dec 18, 2022). Original GitHub issue: https://github.com/glenndehaan/unifi-voucher-site/issues/22 when entering the 'code' its hidden but as it is passed as URL two things happen - the URL: voucher?code=1234&type=480,0,,, is shown Result: the code is visible which can become a potential issue 2. When reloading the page: the system is creating multiple vouchers (when reloading multiple times) 3. System is not aware that there are more options for creating a voucher (week/year), than you need to press the logo again (which can be intentionally)

BreizhHardware closed this issue

2026-05-07 00:17:09 +02:00

BreizhHardware commented

2026-05-07 00:17:10 +02:00

Author

Owner

@glenndehaan commented on GitHub (Dec 18, 2022):

This is all intended

@glenndehaan commented on GitHub (Dec 18, 2022): This is all intended

BreizhHardware commented

2026-05-07 00:17:10 +02:00

Author

Owner

@glenndehaan commented on GitHub (Jan 22, 2024):

Hi,

Due to the changes required to implement #29 I have resolved all of these issues.

Url query parameters a not used anymore within the application
The flow of pages has been changed, there is now a dedicated login page before you can create vouchers.
Due to this flow change: You cannot accidentally create vouchers by refeshing the page
After creating a voucher you will land on the voucher page itself now. This allows you to change the type of voucher you can create for the next creation flow.

Also good to know: #29 introduces a simple Voucher Overview:

Kind regards,
Glenn de Haan

@glenndehaan commented on GitHub (Jan 22, 2024): Hi, Due to the changes required to implement #29 I have resolved all of these issues. - Url query parameters a not used anymore within the application - The flow of pages has been changed, there is now a dedicated login page before you can create vouchers. - Due to this flow change: You cannot accidentally create vouchers by refeshing the page - After creating a voucher you will land on the voucher page itself now. This allows you to change the type of voucher you can create for the next creation flow. Also good to know: #29 introduces a simple Voucher Overview: ![localhost_3000_vouchers](https://github.com/glenndehaan/unifi-voucher-site/assets/7496187/99fc3147-f795-4cb0-a44c-04a9e1012da1) Kind regards, Glenn de Haan

BreizhHardware referenced this issue

2026-05-07 00:18:47 +02:00

[PR #4] [CLOSED] Bump postcss from 8.2.4 to 8.2.15 #77