[PR #149] [MERGED] fix: strip internal routing headers from dev server responses #347

New issue

Closed

opened 2026-05-06 12:39:21 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 12:39:21 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/149
Author: @southpolesteve
Created: 2/27/2026
Status: ✅ Merged
Merged: 2/27/2026
Merged by: @southpolesteve

Base: main ← Head: public/fix-strip-internal-routing-headers

📝 Commits (1)

04f61b0 fix: strip internal routing headers from dev server responses

📊 Changes

3 files changed (+35 additions, -3 deletions)

View changed files

📝 packages/vinext/src/index.ts (+4 -2)
📝 packages/vinext/src/server/app-dev-server.ts (+5 -1)
📝 tests/app-router.test.ts (+26 -0)

📄 Description

Summary

Strips all x-middleware-* prefixed headers from responses in both the App Router and Pages Router dev servers
These are internal routing signals (x-middleware-next, x-middleware-rewrite, x-middleware-override-headers) that should not be visible to clients
The prod server already handled this correctly; this brings the dev servers into parity
Adds test verifying no x-middleware-* headers appear in client responses

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/149 **Author:** [@southpolesteve](https://github.com/southpolesteve) **Created:** 2/27/2026 **Status:** ✅ Merged **Merged:** 2/27/2026 **Merged by:** [@southpolesteve](https://github.com/southpolesteve) **Base:** `main` ← **Head:** `public/fix-strip-internal-routing-headers` --- ### 📝 Commits (1) - [`04f61b0`](https://github.com/cloudflare/vinext/commit/04f61b077d9d6ea9f9ae1a10551c19f5d504520c) fix: strip internal routing headers from dev server responses ### 📊 Changes **3 files changed** (+35 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/index.ts` (+4 -2) 📝 `packages/vinext/src/server/app-dev-server.ts` (+5 -1) 📝 `tests/app-router.test.ts` (+26 -0) </details> ### 📄 Description ## Summary - Strips all `x-middleware-*` prefixed headers from responses in both the App Router and Pages Router dev servers - These are internal routing signals (`x-middleware-next`, `x-middleware-rewrite`, `x-middleware-override-headers`) that should not be visible to clients - The prod server already handled this correctly; this brings the dev servers into parity - Adds test verifying no `x-middleware-*` headers appear in client responses --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>