[PR #353] [MERGED] fix: report App Router render errors to instrumentation #502

New issue

Closed

opened 2026-05-06 13:08:25 +02:00 by BreizhHardware · 0 comments

BreizhHardware commented

2026-05-06 13:08:25 +02:00

Owner

📋 Pull Request Information

Original PR: https://github.com/cloudflare/vinext/pull/353
Author: @NathanDrake2406
Created: 3/8/2026
Status: ✅ Merged
Merged: 3/8/2026
Merged by: @james-elicx

Base: main ← Head: fix/app-router-render-error-reporting

📝 Commits (2)

10f7efa fix: report app router render errors to instrumentation
51b893a refactor: reuse request pathname in render error handlers

📊 Changes

2 files changed (+96 additions, -8 deletions)

View changed files

📝 packages/vinext/src/server/app-dev-server.ts (+69 -8)
📝 tests/app-router.test.ts (+27 -0)

📄 Description

Summary

report App Router Server Component render errors through onRequestError during production RSC rendering
pass request-local route metadata into each RSC onError callback without changing redirect/notFound digest behavior
add a production regression test covering /error-server-test and instrumentation capture

Test Plan

pnpm test tests/app-router.test.ts -t "reports server component render errors via instrumentation in production|rscOnError|App Router Production server"
pnpm test tests/instrumentation.test.ts

Fixes #347

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/cloudflare/vinext/pull/353 **Author:** [@NathanDrake2406](https://github.com/NathanDrake2406) **Created:** 3/8/2026 **Status:** ✅ Merged **Merged:** 3/8/2026 **Merged by:** [@james-elicx](https://github.com/james-elicx) **Base:** `main` ← **Head:** `fix/app-router-render-error-reporting` --- ### 📝 Commits (2) - [`10f7efa`](https://github.com/cloudflare/vinext/commit/10f7efa60a44e091ea126ded42a45dac888b3f57) fix: report app router render errors to instrumentation - [`51b893a`](https://github.com/cloudflare/vinext/commit/51b893a5570c9bb8b2286ffb92e408ef451af9cd) refactor: reuse request pathname in render error handlers ### 📊 Changes **2 files changed** (+96 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/vinext/src/server/app-dev-server.ts` (+69 -8) 📝 `tests/app-router.test.ts` (+27 -0) </details> ### 📄 Description ## Summary - report App Router Server Component render errors through `onRequestError` during production RSC rendering - pass request-local route metadata into each RSC `onError` callback without changing redirect/notFound digest behavior - add a production regression test covering `/error-server-test` and instrumentation capture ## Test Plan - pnpm test tests/app-router.test.ts -t "reports server component render errors via instrumentation in production|rscOnError|App Router Production server" - pnpm test tests/instrumentation.test.ts Fixes #347 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>